Do not allow arrays without comma between values#138
Merged
ncannasse merged 1 commit intoHaxeFoundation:masterfrom Mar 8, 2025
Merged
Do not allow arrays without comma between values#138ncannasse merged 1 commit intoHaxeFoundation:masterfrom
ncannasse merged 1 commit intoHaxeFoundation:masterfrom
Conversation
Member
|
Thanks! |
Idklel01
added a commit
to idklool-things/hscript
that referenced
this pull request
Mar 13, 2025
Do not allow arrays without comma between values (HaxeFoundation#138)
Jamextreme140
added a commit
to CodenameCrew/hscript-improved
that referenced
this pull request
Apr 9, 2025
Do not allow arrays without comma between values (HaxeFoundation#138)
charlesisfeline
pushed a commit
to VsFreyaDevs/hscript3
that referenced
this pull request
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When playing with hscript, I noticed that the parser accepts this array without any comma as value separator:
I don't know if it is an oversight or if it's on purpose, but in my case I needed to forbid it, so here is a pull request of that change.
After the change, the same array needs to be declared like this:
Feel free to merge or close that pull request, depending on whether this is intentional or not!